John Mitchell Posts:2750


| | 02/29/2008 4:19 PM |
| Ok, I can't believe that error hasn't been found until now, but it should be corrected in the attached DLL. Maybe it was happening before but just not noticed until these last changes. | | | |
|
jens lewald
 Posts:40

| | 03/01/2008 2:41 AM |
| sorry but i still have problems, 3/1/2008 9:38:29 AM PB:RequestFilter.MergeCSS: Error Merging CSS Link:D:\LewaldundPartner\Portals\_default\default.css Length cannot be less than zero. Parameter name: length at System.String.InternalSubStringWithChecks(Int32 startIndex, Int32 length, Boolean fAlwaysCopy) at Snapsis.HttpModules.PageBlaster.RequestFilter.MergeCSS(String pageContent) thanks jens
| | | |
|
jens lewald
 Posts:40

| | 03/01/2008 3:17 AM |
| ok, after i write a new default.css the problem is gone. but rights are correct before. this is a complete new optimized default.css. but the problem with incorrect viewing is still there. i will disable merge CSS now and i altough disable the js move, because my js is needed at top not at bottom. i will see if this works for me thanks jens | | | |
|
jens lewald
 Posts:40

| | 03/01/2008 3:24 AM |
| ok, merge css exclude from all works. but i still have some of this errors
http://beta.lundp.de/Kontakt/tabid/141/language/de-DE/plusnb.png (404) shown in firebug thanks jens | | | |
|
caroig
 Posts:30

| | 03/01/2008 8:48 AM |
| I've loaded the new version of the DLL (3.1.0.0) and looking at the trace, the template css and default.css are not loading. 3/1/2008 7:42:33 AM PB:RequestFilter.MergeCSS: Error Merging CSS Link:D:\inetpub\myserver\DesktopModules\DnnForge%20-%20NewsArticles\Templates\AmuNews\Template.css
Could not find a part of the path 'D:\inetpub\myserver\DesktopModules\DnnForge%20-%20NewsArticles\Templates\AmuNews\Template.css'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize)
at System.IO.StreamReader..ctor(String path)
at Snapsis.HttpModules.PageBlaster.RequestFilter.MergeCSS(String pageContent)
3/1/2008 7:42:33 AM PB:RequestFilter.MergeCSS: Error Merging CSS Link:D:\inetpub\myserver\Portals\_default\default.css
Length cannot be less than zero.
Parameter name: length
at System.String.InternalSubStringWithChecks(Int32 startIndex, Int32 length, Boolean fAlwaysCopy)
at Snapsis.HttpModules.PageBlaster.RequestFilter.MergeCSS(String pageContent) | | | |
|
caroig
 Posts:30

| | 03/01/2008 9:04 AM |
| The default.css does seem to load on occasions, but mostly it doesn't. The radmenu css seems to load consistently now. The template.css consistently doesn't load. | | | |
|
John Mitchell Posts:2750


| | 03/01/2008 9:31 AM |
| Ok, these errors are helping and I think I have found where the problem may be with the %20 in the path, and the default.css I have attached a new build which is a debug build that will narrow down where the errors are occuring if they still happen. If you still get errors then please attach your css file along with the error. I know it looks like things are going backwards, but that is just because of the new code to handle the paths in the CSS, so I am sure we are almost there. Thanks. | | | |
|
goBlanks
 Posts:8

| | 03/01/2008 11:05 AM |
| Just passing along info, In relation to this error: Error Merging CSS Link:D:\inetpub\myserver\DesktopModules\DnnForge%20-%20NewsArticles\Templates\AmuNews\Template.css I do know that the %20 is refering to a space in between the words. IE: the actual file folder should read \DNNForge - NewsArticles\ This has no relation to PB at the moment, but I've ran YSlow and reviewed components and have 404 errors with these items: I've checked the file locations and they simply do not exist. Just giving heads up. I'm preparing to install the latest 3.0 build for testing and will report back. Obviously though, if there is no file to reference then this is on the module side and not PB, but in the case of Cariogs situation, that css file exists in ALL News Articles instances......... I'm wondering if this could have an effect on PB, guess well find out soon enough! A fix for this would likely to be for a person to create a blank css file themselves....................
| | My DNN Projects: NortheastOK.com, goBlanks.com | |
|
goBlanks
 Posts:8

| | 03/01/2008 11:08 AM |
| Guess I couldnt post those links,
Anyway my 404 errors were instances of CSS files that did not exist in certain modules and I'm guessing if they don't exist, this could have an adverse impact on PB. | | My DNN Projects: NortheastOK.com, goBlanks.com | |
|
caroig
 Posts:30

| | 03/01/2008 11:17 AM |
| The page appears to display fine in IE7. In firefox the skin does not display. The following is a contiguous extract from 'all css' in the ySlow tools. .LoginContainer { } .photoShadow { float:left; } #tooltip.pretty h3 { font-size:12pt; margin-bottom:0.75em; text-align:center; width:220px; } #tooltip.pretty div { text-align:left; width:220px; } The .photoShadow class is the penultimate line in my default.css and immediately after the float, there is a background class which specifies a url and includes important! . The next class displayed in the ySlow report is around line 700 of my skin.css I've attached the default and skin css files. I'm not seeing any errors in the trace. |
Attachment: 131175029571.zip
| | |
|
jens lewald
 Posts:40

| |
John Mitchell Posts:2750


| | 03/01/2008 5:31 PM |
| Ok, I hope you guys aren't getting tired of this. I took some extra time to test myself on a new DNN 4.8 install with News Articles and I did find the problems with the CSS Minify routies. Here's a new build attached that should handle the CSS problems. |
Attachment: 131314991271.zip
| | |
|
caroig
 Posts:30

| | 03/02/2008 4:32 AM |
| yes, the CSS files all load fine. The only problem I'm observing is with jQuery scripts not running correctly on one of the portals.
I've specified the jQuery library in the page header tags in page settings and it's correctly moved to the bottom of the page by pageblaster and is loaded - I can see this executing jQuery cmds from the firebug console. The actual jQuery script is an inline block in a text/html module on the page and is not moved by the pageblaster process. I guess that the inline script is 'executing' before the jQuery library is loaded. In this particular scenario I can move the inline jQuery out into the header, but I guess this might not always be the case. There are no errors in the trace and the addition of the css merge information is handy. Why not add the same for the JS files? | | | |
|
John Mitchell Posts:2750


| | 03/02/2008 9:07 AM |
| That is correct. For any JS files in the Head it is assumed they can be moved to the bottom. But if there are inline initializations like with the ScriptManager and spmenu then they will have to be moved to the bottom also. I am doing that with replacement rules for the "known" asp.net and dnn js. But you will need to add those rules with others. I can help you create a rule to move the JQuery init to the bottom if you show me one.
I think that is in the Simple Gallery module so I'll try it with that today.
Another way to get around this is to exclude the JQuery stuff from the MergeJS, but then you would miss out on having it optimized of course.
| | | |
|
John Mitchell Posts:2750


| | 03/02/2008 9:08 AM |
| | Oh, and that is a good idea to add debug trace information for the JS files. I'll do that. | | | |
|
John Mitchell Posts:2750


| | 03/02/2008 11:27 AM |
| I installed Simple Gallery and tried moving the jQuery init to the bottom (after the PB merged & cached JS file), but there are still errors.
It looks like they are happening because the jQuery JS file is already heavily optimized.
The best thing for now is to exclude jQuery from the Merge: path pattern="jQuery" excludeFrom="MergeJS" />
| | | |
|
caroig
 Posts:30

| | 03/02/2008 11:34 AM |
| | Simple gallery also uses the jQuery thickbox plugin - this would need to be excluded or moved. My packed jQuery library runs fine after passing through PB - not that i've tested it extensively. | | | |
|
lodani dani
 Posts:45

| | 03/02/2008 4:07 PM |
| John, Thank you very much for the new release, It looks really good. dani | | | |
|
John Mitchell Posts:2750


| | 03/02/2008 4:54 PM |
| Thanks dani, I have found one bug that was able to sneak in when I was doing some cleanup to the UI. New Rules are not being saved correctly.. doh...
Needless to say, I'll have another update out before too long. I have it fixed so if anyone needs an update right away just let me know.
| | | |
|
Duke Rogers
 Posts:1

| | 03/02/2008 11:00 PM |
| A lot of these new features seem to improve an already wonderful module and have piqued my interest, as I am soon launching a production grade fresh dnn 4.8 install. I am not terribly familiar with customizing pb, so I wonder what a realistic date for an RTM grade release is for pb3? As a developer myself I can appreciate what must be stressful days of late and I respect your dedication & patience. -duke | | | |
|